[Backport release-0.17] Fix panic when returning error with provider reference name #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Fixes a panic in the storage container controller that used the provider reference name in the error when we are unable to get the storage account that serves as this type's provider. The ProviderReference may be nil in the case that the newer ProviderConfigReference is used. Signed-off-by: hasheddan <georgedanielmangum@gmail.com> (cherry picked from commit f2a3f79)
Adds a unit test for the storage container reconciler to ensure that we do not panic on usage of providerConfigRef when the storage account is not found. Signed-off-by: hasheddan <georgedanielmangum@gmail.com> (cherry picked from commit 60e6860)
2 tasks
hasheddan
approved these changes
Nov 11, 2021
ulucinar
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #302 to
release-0.17.