cloudsql: implement external tagging #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negz
reviewed
Mar 2, 2020
muvaf
force-pushed
the
tag-cloudsql
branch
3 times, most recently
from
85f2ac0
to
6d24c06
Compare
negz
reviewed
Mar 4, 2020
hasheddan
approved these changes
Mar 4, 2020
|
@negz Updated the runtime dependecy, should be ready to merge. |
|
@muvaf this will have to be rebased to pick up the |
Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
|
@hasheddan thanks for the heads-up! done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
An example implementation of external tagging. This PR depends on crossplane/crossplane-runtime#123 and crossplane/crossplane-tools#17
Fixes #184
Checklist
I have:
make reviewableto ensure this PR is ready for review.app.yamlto include any new role permissions.