Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Managed resources should implement ProviderReferencer interface #17

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Managed resources should implement ProviderReferencer interface #17

merged 1 commit into from
Mar 3, 2020

Conversation

muvaf
Copy link
Member

@muvaf muvaf commented Mar 2, 2020

Description of your changes

Implements changes for crossplane/crossplane-runtime#123

Checklist

I have:

  • Run make reviewable to ensure this PR is ready for review.
  • Ensured this PR contains a neat, self documenting set of commits.

@muvaf
Managed resources should implement ProviderReferencer interface
45cefcc 
Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
@muvaf muvaf mentioned this pull request Mar 2, 2020
Merged
5 tasks
hasheddan
hasheddan approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muvaf muvaf requested a review from negz March 3, 2020 10:10
@muvaf muvaf marked this pull request as ready for review March 3, 2020 10:10
negz
negz approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @muvaf!

@negz negz merged commit b3831cb into crossplane:master Mar 3, 2020
@muvaf muvaf deleted the prover branch March 4, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@negz negz negz approved these changes

@hasheddan hasheddan hasheddan approved these changes

Assignees

@negz negz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@muvaf @negz @hasheddan