Break provider-gcp up by service #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulucinar
force-pushed
the
gcp-family
branch
9 times, most recently
from
3a9176f to
8a5408a
Compare
3 tasks
ulucinar
commented
Apr 26, 2023
package/crossplane-config.yaml
Outdated
There was a problem hiding this comment.
Do we know of a lightweight templating tool that we can quickly integrate into our build pipelines?
ulucinar
force-pushed
the
gcp-family
branch
3 times, most recently
from
1bbafb9 to
70658bc
Compare
- This PR implements the upstream proposal at: crossplane/crossplane#3939 - Subpackages belonging to each API group is produced. An example is: provider-gcp-cloudplatform. - ProviderConfig, ProviderConfigUsage and StoreConfig are part of a config package named provider-gcp-config. - The monolith package (containing all the CRDs and associated controllers) is still produced. - Each produced package except for the monolith package has the `pkg.crossplane.io/provider-family` label in its package metadata. - Each service package except for the config package declares a dependency to the config package. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
- Default the SUBPACKAGES make var to only "monolith" Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
|
/test-examples="examples/cloudplatform/serviceaccount.yaml" |
|
The initial uptest attempt failed and I've observed this previously: I think this is happening because the CRD is not in established state. So, retrying: |
turkenh
approved these changes
Apr 28, 2023
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
|
/test-examples="examples/cloudplatform/serviceaccount.yaml" |
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Relevant proposal: crossplane/crossplane#3939
Depends on: crossplane/upjet#194
This PR proposes the following changes according to the proposal crossplane/crossplane#3939:
pkg.crossplane.io/provider-familylabel in its package metadata.It also introduces the
SUBPACKAGESmake variable so that it's possible to build the individual subpackages. An example for building is:make -j 3 SUBPACKAGES="monolith config cloudplatform" build.allOne can also use the same variable to push those (already built) packages:
make -j 3 SUBPACKAGES="monolith config cloudplatform" BRANCH_NAME=main publishI have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested by building and published the following family of packages using crossplane/upjet#194:
.../upbound/provider-gcp-{group}:v0.31.0-rc.1.9.g5fe711b5, where{group}is a service name such ascloudplatform. There also exists the monolith package.../upbound/provider-gcp:v0.31.0-rc.1.9.g5fe711b5.