Generate per-service providers #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
1 task
ulucinar
force-pushed
the
families
branch
3 times, most recently
from
2f885da to
409f689
Compare
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
1 task
1 task
turkenh
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
I've also successfully tested and verified both the non-breaking behavior and new functionality with crossplane-contrib/provider-upjet-azure#442
So, looking good to me, thanks @ulucinar 🙌
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Relevant proposal: crossplane/crossplane#3939
As discussed in crossplane/crossplane#3939, this PR proposes a change to optionally generate per-service providers. If a provider maintainer opts not to generate the per-service providers, not configuring the
config.Provider.MainTemplateshould result in the old behavior for backwards-compatibility.The backwards-compatibility has been demonstrated here, where the provider does not configure a per-service provider main template.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Tested with crossplane-contrib/provider-upjet-gcp#288 and with crossplane-contrib/provider-upjet-azuread#49 (for backwards-compatibility).