Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Respect custom timeouts during refresh #276

Merged
merged 3 commits into from
May 6, 2022

Conversation

turkenh
Copy link
Member

@turkenh turkenh commented Apr 21, 2022

Description of your changes

With this PR, we will include custom timeouts while building tfstate file during refresh. Terraform stores timeouts as part of provider meta (a.k.a. privateRaw ) and this PR insert timeout meta if there are any.

Fixes #213

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Tested with crossplane-contrib/provider-jet-gcp#61 by creating a bucket.

turkenh added 2 commits April 21, 2022 03:12
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @turkenh

pkg/terraform/files.go Outdated Show resolved Hide resolved
Signed-off-by: Hasan Turken <turkenh@gmail.com>
@turkenh turkenh merged commit 3b673dc into crossplane:main May 6, 2022
@turkenh turkenh deleted the timeouts-to-state branch May 6, 2022 07:19
turkenh added a commit to turkenh/provider-jet-gcp that referenced this pull request May 6, 2022
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configured timeouts not respected during refresh
2 participants