Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: don't set bouncer last_pull until first connection #3020

Merged
merged 2 commits into from
Jun 17, 2024

cscli bouncers prune: query creation date if they never connected

f3518c3
Select commit
Loading
Failed to load commit list.
Merged

db: don't set bouncer last_pull until first connection #3020

cscli bouncers prune: query creation date if they never connected
f3518c3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 12, 2024 in 0s

52.53% (target 0.00%)

View this Pull Request on Codecov

52.53% (target 0.00%)

Details

Codecov Report

Attention: Patch coverage is 66.66667% with 13 lines in your changes missing coverage. Please review.

Project coverage is 52.53%. Comparing base (bd4540b) to head (f3518c3).

Files Patch % Lines
cmd/crowdsec-cli/bouncers.go 33.33% 2 Missing and 2 partials ⚠️
cmd/crowdsec-cli/bouncers_table.go 40.00% 2 Missing and 1 partial ⚠️
pkg/database/decisions.go 66.66% 3 Missing ⚠️
pkg/apiserver/controllers/v1/decisions.go 71.42% 2 Missing ⚠️
pkg/database/bouncers.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3020      +/-   ##
==========================================
+ Coverage   52.49%   52.53%   +0.03%     
==========================================
  Files         281      281              
  Lines       35435    35457      +22     
==========================================
+ Hits        18602    18627      +25     
+ Misses      15011    15005       -6     
- Partials     1822     1825       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.