Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/cticlient: Add missing field in SmokeItem and FireItem #3413

Merged
merged 4 commits into from
Jan 20, 2025

Add tests

19a80cf
Select commit
Loading
Failed to load commit list.
Merged

pkg/cticlient: Add missing field in SmokeItem and FireItem #3413

Add tests
19a80cf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 20, 2025 in 0s

59.32% (target 0.00%)

View this Pull Request on Codecov

59.32% (target 0.00%)

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 59.32%. Comparing base (7d12b80) to head (19a80cf).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/cticlient/types.go 50.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3413      +/-   ##
==========================================
+ Coverage   59.30%   59.32%   +0.01%     
==========================================
  Files         358      358              
  Lines       38412    38428      +16     
==========================================
+ Hits        22781    22797      +16     
- Misses      13738    13740       +2     
+ Partials     1893     1891       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.