Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Recording filters are not correctly updated if error while connecting to target #600

Closed
tthvo opened this issue Nov 1, 2022 · 2 comments · Fixed by #604
Closed
Assignees
Labels
bug Something isn't working

Comments

@tthvo
Copy link
Member

tthvo commented Nov 1, 2022

To reproduce:

  1. Select a target (i.e. authenticated or no-auth) with some recordings.
  2. Switch to another target that causes SSL error or Authentication Failure.
  3. Select Filters category of any kind (e.g. Label, Name).
  4. See the possible filter values of the previous target are still there.

SSL Error:

Screenshot from 2022-11-01 15-05-52

Authentication Failure:

Screenshot from 2022-11-01 15-07-31

Not severely affects the output of the recording tables as error message is shown anyway. But we should correct this and disable the filters somehow if error.

@tthvo tthvo added the bug Something isn't working label Nov 1, 2022
@tthvo
Copy link
Member Author

tthvo commented Nov 1, 2022

From these images, look like its better if we also disable the create button too. Probably better to handle in #601.

@tthvo tthvo self-assigned this Nov 1, 2022
@tthvo tthvo moved this to Todo in 2.3.0 release Nov 1, 2022
@tthvo tthvo changed the title [Task] Target filter states are not correctly switched if error while connecting to target [Task] Recording filters are not correctly updated if error while connecting to target Nov 1, 2022
@tthvo
Copy link
Member Author

tthvo commented Nov 1, 2022

Looks like some states are not cleaned up during errors:

Screenshot from 2022-11-01 16-54-17

9095 causes the error but the table still holds the recordings of previously selected target (i.e. 9091).

@tthvo tthvo moved this to Todo in 2.2.0 Release Nov 1, 2022
Repository owner moved this from Todo to Done in 2.2.0 Release Nov 2, 2022
Repository owner moved this from Todo to Done in 2.3.0 release Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant