Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Error should disable/hide toolbar in tables #601

Closed
tthvo opened this issue Nov 1, 2022 · 1 comment · Fixed by #609
Closed

[Task] Error should disable/hide toolbar in tables #601

tthvo opened this issue Nov 1, 2022 · 1 comment · Fixed by #609
Assignees
@tthvo
Labels
chore Refactor, rename, cleanup, etc.

Comments

@tthvo
Copy link
Member

tthvo commented Nov 1, 2022

We should disable the toolbar (i.e. filters and actions) in tables if there are any errors while querying back-end.

Related to #600
@tthvo tthvo added the chore Refactor, rename, cleanup, etc. label Nov 1, 2022
@tthvo
Copy link
Member Author

tthvo commented Nov 1, 2022

Or we could just hide the toolbar away.

@tthvo tthvo changed the title [Task] Error should disable toolbar in tables [Task] Error should disable/hide toolbar in tables Nov 1, 2022
@tthvo tthvo mentioned this issue Nov 1, 2022
Merged
@tthvo tthvo moved this to Todo in 2.3.0 release Nov 1, 2022
@tthvo tthvo mentioned this issue Nov 1, 2022
Closed
@tthvo tthvo self-assigned this Nov 4, 2022
@tthvo tthvo mentioned this issue Nov 4, 2022
Merged
Repository owner moved this from Todo to Done in 2.3.0 release Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tthvo tthvo

Labels
chore Refactor, rename, cleanup, etc.
Projects
No open projects
2.3.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(toolbar): hide toolbar on errors tthvo/cryostat-web
1 participant
@tthvo