Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(toolbar): hide toolbar on errors #609

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Nov 4, 2022

Fixes #601

Hide all toolbars and only show the error view if an error occurs.

For consistency, use upload icon instead of plus icon in upload table.

@tthvo tthvo added the chore Refactor, rename, cleanup, etc. label Nov 4, 2022
@andrewazores
Copy link
Member

Looks good otherwise.

@andrewazores andrewazores merged commit 108a6df into cryostatio:main Nov 7, 2022
@tthvo tthvo deleted the hide-toolbar-on-error branch November 7, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] Error should disable/hide toolbar in tables
2 participants