Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(recordings): correctly update recording tables on errors #604

Merged
merged 2 commits into from
Nov 2, 2022
Merged

fix(recordings): correctly update recording tables on errors #604

merged 2 commits into from
Nov 2, 2022

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Nov 1, 2022 •
edited
Loading

Fixes #600
Fixes #603
Related to #605

Fixes

  • Clean up recording states if there is an error.
  • Added an error handler for ArchivedRecordingTable to avoid getting stuck in loading state.

Chore

  • Remove call to refreshRecordings in ArchivedRecording upload table as notifications will handle update.

@tthvo tthvo added chore Refactor, rename, cleanup, etc. fix labels Nov 1, 2022
maxcao13
maxcao13 approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@maxcao13 maxcao13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing and code looks good!

@andrewazores andrewazores force-pushed the recording-table-errors branch from 709c950 to 69dfa38 Compare November 2, 2022 19:42
@andrewazores andrewazores merged commit b52ecf9 into cryostatio:main Nov 2, 2022
@tthvo tthvo deleted the recording-table-errors branch November 2, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcao13 maxcao13 maxcao13 approved these changes

@andrewazores andrewazores Awaiting requested review from andrewazores

Assignees
No one assigned
Labels
chore Refactor, rename, cleanup, etc. fix
Projects
No open projects
2.3.0 release
Status: Done
Milestone
No milestone
3 participants
@tthvo @maxcao13 @andrewazores