Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): request necessary permissions #1171

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Dec 5, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #1172
Related to: #1783

Description of the change:

This change adds allows a match expression example to be copied to the clipboard...

Motivation for the change:

This change is helpful because users may want to copy the example for easier use...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

@mergify mergify bot added the safe-to-test label Dec 5, 2023
@aali309 aali309 added the ci label Dec 5, 2023
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Comment on lines +23 to +26
permissions:
issues: write
pull-requests: write
statuses: write
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwangggg
Copy link
Member

mwangggg commented Dec 5, 2023

yes yes that was me being silly - I deleted my comment for that workflow haha. I'm going through and double checking my reviews- I feel like I'm missing something

Copy link
Member

@mwangggg mwangggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@andrewazores andrewazores merged commit 23a2ec9 into cryostatio:main Dec 5, 2023
17 of 18 checks passed
@aali309 aali309 deleted the fixPermission branch December 5, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Meta] CI workflows must request necessary permissions
3 participants