Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): request necessary permissions #1171

Merged
merged 2 commits into from
Dec 5, 2023
Merged

chore(ci): request necessary permissions #1171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1de6adc
added permission to workflows
aali309 Dec 5, 2023
efcb805
resolved issues
aali309 Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ jobs:
with:
firefox-version: latest
- name: Download geckodriver
env:
env:
GECKODRIVER_VERSION: v0.33.0
run: curl -sL https://github.com/mozilla/geckodriver/releases/download/${{env.GECKODRIVER_VERSION}}/geckodriver-${{env.GECKODRIVER_VERSION}}-linux64.tar.gz | tar xzvf -
- name: Add to PATH
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/dependent-issues.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ on:

jobs:
check:
permissions:
issues: write
pull-requests: write
statuses: write
Comment on lines +23 to +26
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/cryostatio/cryostat-web/actions/runs/6952595800/job/18916412442?pr=1153
I thought this was a permission issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need statuses here...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm I'm silly

runs-on: ubuntu-latest
steps:
- uses: z0al/dependent-issues@v1
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/image-cleanup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,14 @@ jobs:
delete-images:
name: Delete PR-scoped test images
runs-on: ubuntu-latest
permissions:
packages: write
steps:
- uses: r26d/ghcr-delete-image-action@v1.2.2
with:
owner: ${{ github.repository_owner }}
name: cryostat-web
token: ${{ secrets.GHCR_PR_TOKEN }}
token: ${{ secrets.GITHUB_TOKEN }}
ignore-missing-package: true
tag-regex: pr-${{ github.event.number }}-.*
tagged-keep-latest: 0
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,13 @@ name: Label pull request

on:
pull_request_target:
types:
types:
- opened
- reopened

jobs:
triage:
permissions:
contents: read
pull-requests: write
runs-on: ubuntu-latest
if: github.actor != 'dependabot[bot]' && github.actor != 'dependabot-preview[bot]'
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/linked-issue.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ on:
jobs:
verify-linked-issue:
runs-on: ubuntu-latest
permissions:
pull-requests: write
if: github.actor != 'dependabot[bot]' && github.actor != 'dependabot-preview[bot]'
name: Verify Pull Request references Issue
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
repo,
comment_id: context.payload.comment.id,
content: "+1",
});
});

checkout-branch:
runs-on: ubuntu-latest
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/pr-labeled.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ on:
jobs:
check-pr-label-and-comment:
runs-on: ubuntu-latest
permissions:
pull-requests: write
steps:
- uses: yashhy/pr-label-check-and-comment-action@v1.0.1
with:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/release-drafter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ on:
jobs:
update_release_draft:
runs-on: ubuntu-latest
permissions:
contents: write
steps:
# Drafts your next Release notes as Pull Requests are merged into "main"
- uses: release-drafter/release-drafter@v5
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/semantic-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ on:
jobs:
main:
runs-on: ubuntu-latest
permissions:
pull-requests: write
statuses: write
steps:
- uses: amannn/action-semantic-pull-request@v3.4.0
env:
Expand Down
Loading