Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(archives): add archives error page #1216

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

mwangggg
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #1028

@mergify mergify bot added the safe-to-test label Feb 16, 2024
@mwangggg mwangggg marked this pull request as draft February 16, 2024 19:47
@mwangggg mwangggg added the fix label Feb 26, 2024
@mwangggg mwangggg force-pushed the 1028-fix-archive-view branch from fdf6e88 to 5b89e9b Compare February 26, 2024 04:45
@mwangggg mwangggg force-pushed the 1028-fix-archive-view branch from 688f3fc to 872777f Compare February 26, 2024 19:23
@mwangggg mwangggg force-pushed the 1028-fix-archive-view branch from c34b0e7 to f516e29 Compare February 26, 2024 22:09
@mwangggg mwangggg requested a review from tthvo February 26, 2024 23:03
@mwangggg mwangggg marked this pull request as ready for review February 26, 2024 23:03
@mwangggg mwangggg force-pushed the 1028-fix-archive-view branch from faeab88 to 9941465 Compare February 26, 2024 23:11
Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs autoformatting applied

@andrewazores andrewazores merged commit 8c5cd31 into cryostatio:main Feb 27, 2024
18 checks passed
@mwangggg mwangggg deleted the 1028-fix-archive-view branch March 12, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] Archive views should indicate errors and allow retry
2 participants