-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(mbeans): adjust MBeanMetrics GraphQL query for updated schema #1219
chore(mbeans): adjust MBeanMetrics GraphQL query for updated schema #1219
Conversation
6c02250
to
d748cee
Compare
This PR/issue depends on: |
/build_test |
This reverts commit 4b904ea.
Test image available:
|
Not sure why the diff here is including #1216 as part of the commit set. That's already merged into main which this is based on top of, but I guess something about the unmerged upstream |
d048ee3
to
0722347
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Depends on cryostatio/cryostat#307
Based on #1218
Description of the change:
Adjusts GraphQL queries for the updated schema in 3.0 where the
mbeanMetrics
subquery is nested under theTarget
object, not under theTargetNode
(theDiscoveryNode
which theTarget
belongs to). Adjusts the client's data model to always expectlabels
andannotations
on Targets returned from the API, whether GraphQL or plain HTTP, and for both labels and annotations to use the new "key-value list" format.Motivation for the change:
Restores the web UI's ability to retrieve MBean Metrics for the Dashboard and Topology, as seen in the screenshot below.
How to manually test: