Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql): adjust GraphQL queries and models for updated server schema #1222

Merged
merged 68 commits into from
Apr 18, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Mar 1, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Includes:

Depends on cryostatio/cryostat#294

Description of the change:

This change adds allows a match expression example to be copied to the clipboard...

Motivation for the change:

This change is helpful because users may want to copy the example for easier use...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

Copy link

github-actions bot commented Mar 1, 2024

Hi @andrewazores! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

Copy link

github-actions bot commented Mar 1, 2024

This PR/issue depends on:

…PI schema (#1220)

* fix(graphql): adjustments for Dashboard Automated Analysis with new API schema
…schema (#1221)

* fix(archives): adjust queries and response handling for updated data schema
@andrewazores
Copy link
Member Author

andrewazores commented Apr 13, 2024

@aali309 could you take a look at updating the unit tests related to the archived recordings views from your recent PR?

https://github.com/cryostatio/cryostat-web/actions/runs/8670862635/job/23779369922

Running yarn test:ci locally should also show the same results.

@andrewazores
Copy link
Member Author

Hmm nevermind, looks like it may have been just a merge issue.

@andrewazores
Copy link
Member Author

Sorry, there was a merge issue, somehow it didn't merge properly from the PR and my first manual attempt was wrong. I think I have corrected it now and there are indeed unit test failures.

@andrewazores
Copy link
Member Author

andrewazores commented Apr 13, 2024

Also, "View in Grafana" on the Uploaded Archives view isn't working. I will help look into that one however, since it may be a similar issue to cryostatio/cryostat#324 on the server side. I tested it with that server side PR checked out as well and the other archived views have a working "View in Grafana", just not that one. I think it might be as simple as a JVM ID base64 encoding bug, or something like that.

@aali309
Copy link
Contributor

aali309 commented Apr 13, 2024

Ok I will look into it also and update you.

@andrewazores andrewazores marked this pull request as ready for review April 18, 2024 22:04
@andrewazores
Copy link
Member Author

/build_test

Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1222-66848cb27b25300ce5f47a7c9b1af208a98fac20 bash smoketest.bash # then open http://localhost:8080

@andrewazores andrewazores merged commit 89e2786 into main Apr 18, 2024
17 of 18 checks passed
@andrewazores andrewazores deleted the cryostat3-graphql branch April 18, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants