Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql): adjustments for Dashboard Automated Analysis with new API schema #1220

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Mar 1, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Based on #1219
Depends on cryostatio/cryostat#312

Description of the change:

This change adds allows a match expression example to be copied to the clipboard...

Motivation for the change:

This change is helpful because users may want to copy the example for easier use...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

image

@mergify mergify bot added the safe-to-test label Mar 1, 2024
@andrewazores andrewazores force-pushed the cryostat3-graphql-dashboard-aar branch from 01229ed to ef3c53a Compare March 1, 2024 21:27
@github-actions github-actions bot removed the dependent label Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

@andrewazores andrewazores marked this pull request as ready for review March 4, 2024 15:14
@andrewazores andrewazores requested review from aali309 and mwangggg March 4, 2024 15:14
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andrewazores andrewazores merged commit 817e32d into cryostatio:cryostat3-graphql Mar 4, 2024
13 of 14 checks passed
@andrewazores andrewazores deleted the cryostat3-graphql-dashboard-aar branch March 4, 2024 18:01
andrewazores added a commit that referenced this pull request Mar 20, 2024
…PI schema (#1220)

* fix(graphql): adjustments for Dashboard Automated Analysis with new API schema
andrewazores added a commit that referenced this pull request Apr 13, 2024
…PI schema (#1220)

* fix(graphql): adjustments for Dashboard Automated Analysis with new API schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants