Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(recordings): remove nested forms #569

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Oct 26, 2022

Fixes #568

Removed the nested Form component in recording creation form.

References: facebook/react#12318 (comment)

@tthvo tthvo added the fix label Oct 26, 2022
Copy link
Member

@maxcao13 maxcao13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@andrewazores andrewazores merged commit 1155826 into cryostatio:main Oct 26, 2022
mergify bot pushed a commit that referenced this pull request Oct 26, 2022
* fix(recordings): remove nested forms

* chore(recording): apply prettier

(cherry picked from commit 1155826)
andrewazores pushed a commit that referenced this pull request Oct 26, 2022
* fix(recordings): remove nested forms

* chore(recording): apply prettier

(cherry picked from commit 1155826)

Co-authored-by: Thuan Vo <thvo@redhat.com>
@tthvo tthvo deleted the remove-nested-forms branch October 26, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] React warns about nested forms
3 participants