Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(recordings): remove nested forms #569

Merged
merged 2 commits into from
Oct 26, 2022
Merged

fix(recordings): remove nested forms #569

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c833dd
fix(recordings): remove nested forms
Oct 26, 2022
0daf027
chore(recording): apply prettier
Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 67 additions & 73 deletions src/app/CreateRecording/CustomRecordingForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,79 +393,73 @@ export const CustomRecordingForm = (props) => {
</FormGroup>
</ExpandableSection>
<ExpandableSection toggleTextExpanded="Hide advanced options" toggleTextCollapsed="Show advanced options">
<Form>
<Text component={TextVariants.small}>A value of 0 for maximum size or age means unbounded.</Text>
<FormGroup
fieldId="To Disk"
helperText="Write contents of buffer onto disk. If disabled, the buffer acts as circular buffer only keeping the most recent recording information"
>
<Checkbox label="To Disk" id="toDisk-checkbox" isChecked={toDisk} onChange={handleToDiskChange} />
</FormGroup>
<FormGroup
label="Maximum size"
fieldId="maxSize"
helperText="The maximum size of recording data saved to disk"
>
<Split hasGutter={true}>
<SplitItem isFilled>
<TextInput
value={maxSize}
isRequired
type="number"
id="maxSize"
aria-label="max size value"
onChange={handleMaxSizeChange}
min="0"
isDisabled={!toDisk}
/>
</SplitItem>
<SplitItem>
<FormSelect
value={maxSizeUnits}
onChange={handleMaxSizeUnitChange}
aria-label="Max size units input"
isDisabled={!toDisk}
>
<FormSelectOption key="1" value="1" label="B" />
<FormSelectOption key="2" value={1024} label="KiB" />
<FormSelectOption key="3" value={1024 * 1024} label="MiB" />
</FormSelect>
</SplitItem>
</Split>
</FormGroup>
<FormGroup
label="Maximum age"
fieldId="maxAge"
helperText="The maximum age of recording data stored to disk"
>
<Split hasGutter={true}>
<SplitItem isFilled>
<TextInput
value={maxAge}
isRequired
type="number"
id="maxAgeDuration"
aria-label="Max age duration"
onChange={handleMaxAgeChange}
min="0"
isDisabled={!continuous || !toDisk}
/>
</SplitItem>
<SplitItem>
<FormSelect
value={maxAgeUnits}
onChange={handleMaxAgeUnitChange}
aria-label="Max Age units Input"
isDisabled={!continuous || !toDisk}
>
<FormSelectOption key="1" value="1" label="Seconds" />
<FormSelectOption key="2" value={60} label="Minutes" />
<FormSelectOption key="3" value={60 * 60} label="Hours" />
</FormSelect>
</SplitItem>
</Split>
</FormGroup>
</Form>
<Text component={TextVariants.small}>A value of 0 for maximum size or age means unbounded.</Text>
<FormGroup
fieldId="To Disk"
helperText="Write contents of buffer onto disk. If disabled, the buffer acts as circular buffer only keeping the most recent recording information"
>
<Checkbox label="To Disk" id="toDisk-checkbox" isChecked={toDisk} onChange={handleToDiskChange} />
</FormGroup>
<FormGroup
label="Maximum size"
fieldId="maxSize"
helperText="The maximum size of recording data saved to disk"
>
<Split hasGutter={true}>
<SplitItem isFilled>
<TextInput
value={maxSize}
isRequired
type="number"
id="maxSize"
aria-label="max size value"
onChange={handleMaxSizeChange}
min="0"
isDisabled={!toDisk}
/>
</SplitItem>
<SplitItem>
<FormSelect
value={maxSizeUnits}
onChange={handleMaxSizeUnitChange}
aria-label="Max size units input"
isDisabled={!toDisk}
>
<FormSelectOption key="1" value="1" label="B" />
<FormSelectOption key="2" value={1024} label="KiB" />
<FormSelectOption key="3" value={1024 * 1024} label="MiB" />
</FormSelect>
</SplitItem>
</Split>
</FormGroup>
<FormGroup label="Maximum age" fieldId="maxAge" helperText="The maximum age of recording data stored to disk">
<Split hasGutter={true}>
<SplitItem isFilled>
<TextInput
value={maxAge}
isRequired
type="number"
id="maxAgeDuration"
aria-label="Max age duration"
onChange={handleMaxAgeChange}
min="0"
isDisabled={!continuous || !toDisk}
/>
</SplitItem>
<SplitItem>
<FormSelect
value={maxAgeUnits}
onChange={handleMaxAgeUnitChange}
aria-label="Max Age units Input"
isDisabled={!continuous || !toDisk}
>
<FormSelectOption key="1" value="1" label="Seconds" />
<FormSelectOption key="2" value={60} label="Minutes" />
<FormSelectOption key="3" value={60 * 60} label="Hours" />
</FormSelect>
</SplitItem>
</Split>
</FormGroup>
</ExpandableSection>
<ActionGroup>
<Button variant="primary" onClick={handleSubmit} isDisabled={isFormInvalid}>
Expand Down