Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rules): rename Automatic to Automated #693

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

andrewazores
Copy link
Member

Fixes #692

@tthvo
Copy link
Member

tthvo commented Nov 29, 2022

Looks good! I think there is one more spot in CreateRule.tsx, that set the spinnerAriaLabel and still uses Automatic :D

Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :D

@andrewazores andrewazores merged commit 54c6853 into cryostatio:main Nov 29, 2022
@andrewazores andrewazores deleted the retitle-automatic-rules branch November 29, 2022 16:30
mergify bot pushed a commit that referenced this pull request Nov 29, 2022
* fix(rules): rename Automatic to Automated

* fixup! fix(rules): rename Automatic to Automated

(cherry picked from commit 54c6853)

# Conflicts:
#	src/app/Rules/CreateRule.tsx
#	src/app/Rules/RulesUploadModal.tsx
andrewazores added a commit that referenced this pull request Nov 29, 2022
* fix(rules): rename Automatic to Automated (#693)

* fix(rules): rename Automatic to Automated

* fixup! fix(rules): rename Automatic to Automated

(cherry picked from commit 54c6853)

# Conflicts:
#	src/app/Rules/CreateRule.tsx
#	src/app/Rules/RulesUploadModal.tsx

* fixup! fix(rules): rename Automatic to Automated (#693)

Co-authored-by: Andrew Azores <aazores@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] Fix inconsistent text
2 participants