Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rules): rename Automatic to Automated #693

Merged
merged 2 commits into from
Nov 29, 2022
Merged

fix(rules): rename Automatic to Automated #693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
754e9e7
fix(rules): rename Automatic to Automated
andrewazores Nov 29, 2022
dbef07b
fixup! fix(rules): rename Automatic to Automated
andrewazores Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/Rules/CreateRule.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ const Comp: React.FunctionComponent<{}> = () => {
() =>
({
spinnerAriaValueText: 'Creating',
spinnerAriaLabel: 'creating-automatic-rule',
spinnerAriaLabel: 'creating-automated-rule',
isLoading: loading,
} as LoadingPropsType),
[loading]
Expand Down
8 changes: 4 additions & 4 deletions src/app/Rules/RulesUploadModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const parseRule = (file: File): Observable<Rule> => {
if (isRule(obj)) {
return obj;
} else {
throw new Error('Automatic rule content is invalid.');
throw new Error('Automated rule content is invalid.');
}
})
);
Expand Down Expand Up @@ -152,7 +152,7 @@ export const RuleUploadModal: React.FunctionComponent<RuleUploadModalProps> = (p
() =>
({
spinnerAriaValueText: 'Submitting',
spinnerAriaLabel: 'submitting-automatic-rule',
spinnerAriaLabel: 'submitting-automated-rule',
isLoading: uploading,
} as LoadingPropsType),
[uploading]
Expand All @@ -166,8 +166,8 @@ export const RuleUploadModal: React.FunctionComponent<RuleUploadModalProps> = (p
variant={ModalVariant.large}
showClose={!uploading}
onClose={handleClose}
title="Upload Automatic Rules"
description="Select an Automatic Rules definition file to upload. File must be in valid JSON format."
title="Upload Automated Rules"
description="Select an Automated Rules definition file to upload. File must be in valid JSON format."
help={
<Popover
headerContent={<div>What's this?</div>}
Expand Down
4 changes: 2 additions & 2 deletions src/test/Rules/Rules.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ describe('<Rules />', () => {
expect(modal).toBeInTheDocument();
expect(modal).toBeVisible();

const modalTitle = await within(modal).findByText('Upload Automatic Rules');
const modalTitle = await within(modal).findByText('Upload Automated Rules');
expect(modalTitle).toBeInTheDocument();
expect(modalTitle).toBeVisible();

Expand Down Expand Up @@ -270,7 +270,7 @@ describe('<Rules />', () => {
expect(modal).toBeInTheDocument();
expect(modal).toBeVisible();

const modalTitle = await within(modal).findByText('Upload Automatic Rules');
const modalTitle = await within(modal).findByText('Upload Automated Rules');
expect(modalTitle).toBeInTheDocument();
expect(modalTitle).toBeVisible();

Expand Down