-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(gameserver): split sample for JDK versions #579
test(gameserver): split sample for JDK versions #579
Conversation
This PR/issue depends on: |
/build_test |
Workflow started at 7/23/2024, 12:43:22 PM. View Actions Run. |
No GraphQL schema changes detected. |
No OpenAPI schema changes detected. |
Looks like the tests are failing on this PR same as yours. Makes sense on the one hand because there's no way your PR should have broken anything, but then the question is what is broken and why/how? |
CI build and push: At least one test failed ❌ (JDK17) |
63d28f2
to
d9a8022
Compare
/build_test |
Workflow started at 7/23/2024, 1:01:35 PM. View Actions Run. |
I first thought that https://github.com/cryostatio/cryostat/compare/721eb12c4e2609c2ebd6fcad4b4463ce5e073da0..351ad38c9d2bf9af1bc835cefdbf564415ef1dc3 changes could potentially be the reason. Agent is set to public potentially open up the Agent to be accessible from a broader network than before, but Its not the case |
Not possible, nothing from Anyway, that setting doesn't "open up" the Agent, it loosens a restriction that the Agent imposes upon itself for what network locations it will accept for the Cryostat server it will connect to. |
No OpenAPI schema changes detected. |
No GraphQL schema changes detected. |
CI build and push: At least one test failed ❌ (JDK17) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Related to #572
Depends on cryostatio/test-applications#15
See cryostatio/test-applications#14
Description of the change:
This change allows an environment variable to be configured so that...
Motivation for the change:
This change is helpful because users may want to...
How to manually test: