Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(gameserver): split sample for JDK versions #579

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Jul 23, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #572
Depends on cryostatio/test-applications#15
See cryostatio/test-applications#14

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

Copy link

@aali309
Copy link
Contributor

aali309 commented Jul 23, 2024

/build_test

Copy link

Workflow started at 7/23/2024, 12:43:22 PM. View Actions Run.

Copy link

No GraphQL schema changes detected.

Copy link

No OpenAPI schema changes detected.

@andrewazores
Copy link
Member Author

Looks like the tests are failing on this PR same as yours. Makes sense on the one hand because there's no way your PR should have broken anything, but then the question is what is broken and why/how?

Copy link

CI build and push: At least one test failed ❌ (JDK17)
https://github.com/cryostatio/cryostat/actions/runs/10062912520

@andrewazores andrewazores force-pushed the gameserver-versions branch from 63d28f2 to d9a8022 Compare July 23, 2024 17:00
@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 7/23/2024, 1:01:35 PM. View Actions Run.

@aali309
Copy link
Contributor

aali309 commented Jul 23, 2024

I first thought that https://github.com/cryostatio/cryostat/compare/721eb12c4e2609c2ebd6fcad4b4463ce5e073da0..351ad38c9d2bf9af1bc835cefdbf564415ef1dc3 changes could potentially be the reason. Agent is set to public potentially open up the Agent to be accessible from a broader network than before, but Its not the case

@andrewazores
Copy link
Member Author

andrewazores commented Jul 23, 2024

Not possible, nothing from compose/ or the smoketest in general is involved in CI runs.

Anyway, that setting doesn't "open up" the Agent, it loosens a restriction that the Agent imposes upon itself for what network locations it will accept for the Cryostat server it will connect to.

Copy link

No OpenAPI schema changes detected.

Copy link

No GraphQL schema changes detected.

Copy link

CI build and push: At least one test failed ❌ (JDK17)
https://github.com/cryostatio/cryostat/actions/runs/10063146349

Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andrewazores andrewazores merged commit 1929e79 into cryostatio:main Jul 23, 2024
8 of 9 checks passed
@andrewazores andrewazores deleted the gameserver-versions branch July 23, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants