Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(gameserver): build with multiple JDK versions #14

Merged

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Based on #13

Description of the change:

Builds the gameserver container with an array of JDK versions.

Motivation for the change:

Currently, all three images are only built and published based on JDK17. Since these are all intended for testing various combinations of components to ensure compatibility and functionality, it's important for our test scenarios to cover as many supported combinations as is feasible.

How to manually test:

  1. Check out PR
  2. ./gameserver/build.bash

@andrewazores andrewazores force-pushed the gameserver-multi-jdk-versions branch from b364566 to 88cd6d3 Compare July 23, 2024 15:52
@andrewazores andrewazores merged commit 62aede6 into cryostatio:main Jul 23, 2024
2 checks passed
@andrewazores andrewazores deleted the gameserver-multi-jdk-versions branch July 23, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants