Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly dist_linux is broken by shards #10861

Closed
straight-shoota opened this issue Jun 30, 2021 · 1 comment · Fixed by #10862
Closed

Nightly dist_linux is broken by shards #10861

straight-shoota opened this issue Jun 30, 2021 · 1 comment · Fixed by #10862
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:infrastructure

Comments

@straight-shoota
Copy link
Member

Building shards on the latest nightly run of dist_linux and dist_linux32 breaks:

https://app.circleci.com/pipelines/github/crystal-lang/crystal/6114/workflows/f56b1316-4d01-4c00-9265-a3d31d3f14cd/jobs/61739
https://app.circleci.com/pipelines/github/crystal-lang/crystal/6114/workflows/f56b1316-4d01-4c00-9265-a3d31d3f14cd/jobs/61737

This is still with the old shards release 0.14.1. I can't see any connection to the new release 0.15.0, although it looks somewhat suspicious that it appears in the CI run after 0.15.0 was released.

The error seems to be caused by the Makefile recipe for shard.lock, which fails because shards binary is not available (SHARDS=false). This recipe should not be used because shard.lock exists and it should not be older than shard.yml. However, I think that's not necessarily guaranteed. So the cause could be a coincidental mismatch between shard.yml and shard.lock timestamps while checking out the repository. But it appears in both jobs simultaneously. That's also suspicious.

The fix should be easy (avoid running $(SHARDS) update if $SHARDS = false). But it's strange why this error appears suddenly.

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:infrastructure labels Jun 30, 2021
@straight-shoota
Copy link
Member Author

This also reproduces when I run the distributions scripts locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant