Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Makefile] Fix shard.lock recipe #515

Merged

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Jun 30, 2021

The shard.lock recipe fails if SHARDS=false (i.e. building from scratch without a previously installed shards binary), we must skip $SHARDS update in that case.

see crystal-lang/crystal#10861

Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@beta-ziliani beta-ziliani added this to the vNext milestone Aug 18, 2021
@straight-shoota straight-shoota merged commit 635d36a into crystal-lang:master Aug 23, 2021
@straight-shoota straight-shoota deleted the fix/make-shardlock branch August 23, 2021 14:33
straight-shoota added a commit to crystal-lang/distribution-scripts that referenced this pull request Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants