Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor performance improvements to HTTP::Cookies #10488

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Mar 9, 2021

Adds three small improvemnts with regard to collection operations in HTTP::Cookies.

The capacity calculation currently underestimates because it doesn't take URI encoding into account. With #10485 it is 100% accurate.

Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @straight-shoota 🙏

@sdogruyol sdogruyol merged commit 9a3d0c4 into crystal-lang:master Mar 10, 2021
@straight-shoota straight-shoota deleted the refactor/cookies-collection-performance branch March 10, 2021 11:31
@bcardiff bcardiff added this to the 1.0.0 milestone Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants