Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor performance improvements to HTTP::Cookies #10488

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Minor performance improvements to HTTP::Cookies #10488

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88098ce
Use each_value instead of values.each
straight-shoota Mar 9, 2021
0f06405
Override headers["Cookie"] and build string without intermediate
straight-shoota Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/http/cookie.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,8 @@ module HTTP
end

# Yields each `HTTP::Cookie` in the collection.
def each(&block : Cookie ->)
@cookies.values.each do |cookie|
def each(& : Cookie ->)
@cookies.each_value do |cookie|
yield cookie
end
end
Expand All @@ -297,8 +297,15 @@ module HTTP
# given `HTTP::Headers` instance and returns it. Removes any existing
# `Cookie` headers in it.
def add_request_headers(headers)
headers.delete("Cookie")
headers.add("Cookie", map(&.to_cookie_header).join("; ")) unless empty?
if empty?
headers.delete("Cookie")
else
capacity = sum { |cookie| cookie.name.bytesize + cookie.value.bytesize + 1 }
capacity += (size - 1) * 2
headers["Cookie"] = String.build(capacity) do |io|
join(io, "; ", &.to_cookie_header(io))
end
end

headers
end
Expand Down