Define #system_echo
and #system_raw
on all systems
#12352
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #12294. The breaking changes are:
#noecho!
and#raw!
returnnil
instead ofLibC.tcsetattr
's return value;*_from_tc_mode!
macros are now deprecated.Later we should probably deprecate
Termios
as well, since it is now only used from withinsrc/crystal/system/unix/file_descriptor.cr
.I have no idea if these functions make sense on WASI. They are left unimplemented.