Deprecate Termios
#12940
Merged
Deprecate Termios
#12940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #12352.
The top-level
Termiossolely exists to turn the C enum values used by the few console methods onIO::FileDescriptorinto Crystal enums; it is very platform-specific, the vast majority of those constants are unused anywhere else, andTermios::OutputModedoesn't even have the same members on all platforms (contrast with signals andErrno). This PR deprecatesTermiosand all of its enums.The deprecations don't actually do anything yet, until #12939 is implemented. Also the constants inside
LibCare untouched, because technicallyTermiosstill depends on them.