Drop support for LLVM < 8 #12906
Merged
Drop support for LLVM < 8 #12906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A big chunk of LLVM version checks in the standard library that call |
|
Oh, I completely missed those. 🤦♂️ |
HertzDevil
reviewed
Jan 17, 2023
Comment on lines
+168
to
+169
| {% else %} | ||
| fun create_type_attribute = LLVMCreateTypeAttribute(ctx : LibLLVM::ContextRef, kind_id : LibC::UInt, ty : LibLLVM::TypeRef) : LibLLVM::AttributeRef |
There was a problem hiding this comment.
This should go into LibLLVM, not here. Same for the LLVMDIBuilder* functions above
There was a problem hiding this comment.
But in libllvm it's only defined in version >= 13. So we'd have to switch at the callsite. IMO it's easier this way, switching the bindings. Even though it's a bit sloppy.
There was a problem hiding this comment.
And the DIBuilder functions still use LibLLVMExt::DIBuilder type, hence I opted to leave the bindings here where all the other DIBuilder functions are defined as well.
bcardiff
approved these changes
Jan 17, 2023
HertzDevil
approved these changes
Jan 17, 2023
bcardiff
approved these changes
Jan 18, 2023
This was referenced Mar 7, 2023
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8725
Closes #11403