-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OAuth2::Client#make_token_request
returning HTTP response
#12921
Add OAuth2::Client#make_token_request
returning HTTP response
#12921
Conversation
And make it flexible to add additional request headers
Thanks for this patch. I think we should talk about the reasoning behind this and potentially evaluate alternative API solutions. |
…p response object
src/oauth2/client.cr
Outdated
} | ||
|
||
# Makes a token exchange request with custom headers and form fields | ||
# Returns a HTTP::Client::Response |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is superfluous. The return type is sufficiently indicated in the method signature.
# Returns a HTTP::Client::Response |
…ent_get_access_token
…le/crystal into expose_OAuth2_Client_get_access_token
OAuth2::Client#make_token_request
returning HTTP response
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @cyangle 🙏
Make OAuth2::Client#get_access_token a public method
So that one can pass custom headers and form params