-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OAuth2::Client#make_token_request
returning HTTP response
#12921
Merged
straight-shoota
merged 10 commits into
crystal-lang:master
from
cyangle:expose_OAuth2_Client_get_access_token
Feb 6, 2023
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0f0a207
Expose Oauth::Client#get_access_token method
cyangle 0f77754
Refactor code styles in src/oauth2/client.cr
cyangle 854743e
Refactor by adding a new method make_token_request that returns a htt…
cyangle 3843bf6
Merge branch 'master' into expose_OAuth2_Client_get_access_token
cyangle 55c18aa
Merge branch 'master' into expose_OAuth2_Client_get_access_token
cyangle 74e2f52
Merge branch 'master' into expose_OAuth2_Client_get_access_token
cyangle ac5f901
Merge remote-tracking branch 'upstream/master' into expose_OAuth2_Cli…
cyangle a0d294d
Merge branch 'expose_OAuth2_Client_get_access_token' of cyangle:cyang…
cyangle 3248cc7
Address PR comment
cyangle 5bc6609
Fix format error
cyangle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is superfluous. The return type is sufficiently indicated in the method signature.