Improve File.symlink on Windows
#13141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Denis Maslennikov <mrdenniska@gmail.com>
straight-shoota
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
I guess it wouldn't hurt to add the original comment about developer mode? https://github.com/crystal-lang/crystal/pull/9676/files#diff-7998f91927fcec8f736bd944a03598f8aecd89dad9304094738ad5508537be03R201-R204
Co-authored-by: Beta Ziliani <beta@manas.tech>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-issue of #9676. This allows creation of directory symlinks and falls back to default symlink creation if the developer mode flag is not supported. (The developer mode flag is itself added in #9767 already.)
(also my first attempt at a co-authored PR on GitHub)