Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve File.symlink for Windows #9676

Closed
wants to merge 1 commit into from

Conversation

nof1000
Copy link
Contributor

@nof1000 nof1000 commented Aug 15, 2020

That's implements symlink on Windows. But please note that we cannot make symlink on Windows without Administrator privileges. It might be is worth writing about this in the documentation

@straight-shoota
Copy link
Member

It might be is worth writing about this in the documentation

Could you add such a note to File.symlink?

Also needs a rebase.

@mominshaikhdevs
Copy link

please note that we cannot make symlink on Windows without Administrator privileges.

This is Wrong.
Starting with Windows 10 v14972 and upwards, one can enable symlinks without admin privileges when Developer Mode is enabled. (settings > updates and security > for developers > toggle the developer mode on).

** https://blogs.windows.com/windowsdeveloper/2016/12/02/symlinks-windows-10/

** https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-createsymboliclinkw
( notice the flag SYMBOLIC_LINK_FLAG_ALLOW_UNPRIVILEGED_CREATE ).

** https://learn.microsoft.com/en-us/windows/apps/get-started/enable-your-device-for-development

@straight-shoota
Copy link
Member

@mominshaikhdevs Thanks for clarification. This is actually mentioned in the code comment, btw.

@straight-shoota straight-shoota added the help wanted This issue is generally accepted and needs someone to pick it up label Feb 9, 2023
@mominshaikhdevs
Copy link

should this PR be closed since #13141 is merged ?

@beta-ziliani
Copy link
Member

Indeed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted This issue is generally accepted and needs someone to pick it up kind:feature platform:windows pr:needs-work A PR requires modifications by the author. topic:stdlib:files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants