Handle NaNs when comparing BigInt against Float
#13293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
changed the title
NaNs when comparing BigInt against FloatBigInt against Float
straight-shoota
approved these changes
Apr 6, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing a
BigIntagainst eitherFloat64::NANorFloat32::NANwill raise SIGFPE. This PR fixes that by making#<=>returnnilif that is the case.LibGMP.cmp_dalready handles infinities, by the way.Comparisons between
BigInts andBigFloats aren't affected, as GMP'sBigFloatdoes not support NaNs (but MPFR's does).This is a breaking change because previously those return types weren't nilable.