Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle NaNs when comparing BigInt against Float #13293

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Handle NaNs when comparing BigInt against Float #13293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions spec/std/big/big_int_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,19 @@ describe "BigInt" do
1.1.should_not eq(1.to_big_i)

[1.1, 1.to_big_i, 3.to_big_i, 2.2].sort.should eq([1, 1.1, 2.2, 3])

(1.to_big_i <=> Float64::NAN).should be_nil
(1.to_big_i <=> Float32::NAN).should be_nil
(Float64::NAN <=> 1.to_big_i).should be_nil
(Float32::NAN <=> 1.to_big_i).should be_nil

typeof(1.to_big_i <=> Float64::NAN).should eq(Int32?)
typeof(1.to_big_i <=> Float32::NAN).should eq(Int32?)
typeof(Float64::NAN <=> 1.to_big_i).should eq(Int32?)
typeof(Float32::NAN <=> 1.to_big_i).should eq(Int32?)

typeof(1.to_big_i <=> 1.to_big_f).should eq(Int32)
typeof(1.to_big_f <=> 1.to_big_i).should eq(Int32)
end

it "divides and calculates the modulo" do
Expand Down
7 changes: 4 additions & 3 deletions src/big/big_int.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,8 @@ struct BigInt < Int
end
end

def <=>(other : Float)
LibGMP.cmp_d(mpz, other)
def <=>(other : Float::Primitive)
LibGMP.cmp_d(mpz, other) unless other.nan?
end

def +(other : BigInt) : BigInt
Expand Down Expand Up @@ -811,7 +811,8 @@ struct Float
include Comparable(BigInt)

def <=>(other : BigInt)
-(other <=> self)
cmp = other <=> self
-cmp if cmp
end

# Returns a `BigInt` representing this float (rounded using `floor`).
Expand Down