Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode to docs #13512

Merged

Conversation

GeopJr
Copy link
Contributor

@GeopJr GeopJr commented May 27, 2023

Hopefully I didn't miss anything 😅

The colors are close to the original ones but lighter enough to pass wcag

Light Dark
Screenshot from 2023-05-27 09-37-34 Screenshot from 2023-05-27 09-37-26
Screenshot from 2023-05-27 09-45-10 Screenshot from 2023-05-27 09-45-17
Screenshot from 2023-05-27 09-46-48 image

Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Contrast is actually quite a bit stronger in dark mode. It could be toned down a bit. But I suppose it's fine.

@GeopJr
Copy link
Contributor Author

GeopJr commented May 27, 2023

Does this look any better?

Screenshot from 2023-05-28 01-28-56

image

@straight-shoota straight-shoota added this to the 1.9.0 milestone Jun 5, 2023
@straight-shoota straight-shoota merged commit b91648f into crystal-lang:master Jun 6, 2023
@GeopJr GeopJr deleted the feat/docs-generator/dark-mode branch June 6, 2023 09:07
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants