Add mobile support to docs #13515
Merged
Add mobile support to docs #13515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat/docs-generator/mobile
straight-shoota
approved these changes
Jun 6, 2023
HertzDevil
approved these changes
Jun 15, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds mobile support to docs
There hasn't been any prior discussion/communication about this, so it may require a lot of changes. The key parts are:
lastOpenType.scrollIntoViewis no longer on top, becauseDOMContentLoadedis emitted before CSS is done (causing the open type to not be in view)output.webm
Screencast.from.2023-05-29.14-14-41.webm
fix: #13489
TODO: change open svg color to white on dark mode when #13512 gets merged