Avoid double file buffering #13780
Merged
Avoid double file buffering #13780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +33,7 @@ module Crystal::System::Random | |||
| return unless urandom.info.type.character_device? | |||
|
|
|||
| urandom.close_on_exec = true | |||
| urandom.sync = true # don't buffer bytes | |||
| urandom.read_buffering = false # don't buffer bytes | |||
There was a problem hiding this comment.
For context: sync controls write buffering, which is completely irrelevant here. read_buffering is used to control read buffering.
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
straight-shoota
approved these changes
Sep 20, 2023
HertzDevil
approved these changes
Sep 20, 2023
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid allocating file buffers when not needed.