-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid double file buffering #13780
Merged
straight-shoota
merged 7 commits into
crystal-lang:master
from
carlhoerberg:avoid-double-file-buffering
Sep 22, 2023
Merged
Avoid double file buffering #13780
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ee34463
Don't buffer urandom bytes
carlhoerberg 3945739
Don't double buffer when digesting
carlhoerberg a22a515
Don't write buffer when doing a simple File.write
carlhoerberg 9b7f07c
Update src/digest/digest.cr
carlhoerberg 6daeef9
Only disable buffering in File.write for Bytes and Strings
carlhoerberg 7696be8
only dislabe buffering in File.write for bytes
carlhoerberg 09ab0b6
dsiable buffering for File.write for IOs too
carlhoerberg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For context:
sync
controls write buffering, which is completely irrelevant here.read_buffering
is used to control read buffering.