-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support LLVM 17 #13782
Merged
straight-shoota
merged 8 commits into
crystal-lang:master
from
HertzDevil:feature/llvm-17
Oct 5, 2023
Merged
Support LLVM 17 #13782
straight-shoota
merged 8 commits into
crystal-lang:master
from
HertzDevil:feature/llvm-17
Oct 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If it works on Windows, let's assume LLVM 17 does work and leave out the Linux CI for later |
straight-shoota
approved these changes
Oct 4, 2023
Merged
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No problems are found with 17.0.0-rc3 so far (
17.0.0~++20230829063235+da76a22ae9ff-1~exp1~20230829063338.35
to be exact). No code changes are required as they were sorted out in #13579 already.Note that there is indeed no 17.0.0 stable. The first stable release of LLVM 17 is 17.0.1.
Linux CI will have to wait until their volunteers upload the pre-built LLVM package. Windows CI should be ready; this PR also includes a fix for the LLVM cache. (Previously it was broken but went unnoticed as the CI cache for LLVM 16 was never evicted.)