Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix win.yml #13876

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Fix win.yml #13876

merged 1 commit into from
Oct 10, 2023

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Oct 9, 2023

#13782 broke Windows CI but this went unnoticed because GitHub actions does not properly report broken CI configuration.

@beta-ziliani
Copy link
Member

this is the only way to fix it? can it be fixed in a way that it keeps the original spirit of taking the version from configuration?

@straight-shoota
Copy link
Member Author

@beta-ziliani I have no idea if there could be a better solution and I didn't find anything useful so far. This makes it work. We can improve later if we find a better way to do it.

@straight-shoota straight-shoota added this to the 1.11.0 milestone Oct 10, 2023
@straight-shoota straight-shoota merged commit 8cd1481 into master Oct 10, 2023
163 checks passed
@straight-shoota straight-shoota deleted the fix/ci-win.yml branch October 10, 2023 18:49
@straight-shoota straight-shoota modified the milestones: 1.11.0, 1.10.1 Oct 12, 2023
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants