Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose macro Call context via new @caller macro ivar #14048

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Expose macro Call context via new @caller macro ivar #14048

merged 3 commits into from
Dec 21, 2023

Conversation

Blacksmoke16
Copy link
Member

@Blacksmoke16 Blacksmoke16 commented Dec 5, 2023 •
edited
Loading

resolves #14055

This was referenced Dec 5, 2023
Merged
Closed
@straight-shoota straight-shoota mentioned this pull request Dec 5, 2023
Closed
@straight-shoota
Copy link
Member

straight-shoota commented Dec 5, 2023 •
edited
Loading

This is a major new API feature and I believe it actually needs a bit more dedicated discussion first. Let's to that in #14055.
I'm converting this PR to a draft until the feature API is finalized.

@straight-shoota straight-shoota marked this pull request as draft December 5, 2023 17:01
@straight-shoota straight-shoota mentioned this pull request Dec 6, 2023
Open
@Blacksmoke16
Copy link
Member Author

Marking this as ready for review again. This should be a good initial implementation based on the discussion in #14055.

@Blacksmoke16 Blacksmoke16 marked this pull request as ready for review December 19, 2023 19:21
straight-shoota
straight-shoota reviewed Dec 19, 2023
View reviewed changes
spec/compiler/codegen/macro_spec.cr Outdated Show resolved Hide resolved
spec/compiler/codegen/macro_spec.cr Outdated Show resolved Hide resolved
straight-shoota
straight-shoota approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good for a first implementation.

@straight-shoota straight-shoota added this to the 1.11.0 milestone Dec 19, 2023
@Blacksmoke16 Blacksmoke16 mentioned this pull request Dec 20, 2023
Merged
@straight-shoota straight-shoota merged commit 3885078 into crystal-lang:master Dec 21, 2023
54 of 55 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jan 8, 2024
Merged
1 task
@Blacksmoke16 Blacksmoke16 mentioned this pull request Feb 6, 2024
Closed
@Blacksmoke16 Blacksmoke16 deleted the caller-macro-ivar branch May 5, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:feature topic:lang:macros
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

Exposing a macro's caller
2 participants
@Blacksmoke16 @straight-shoota