Expose doc comments on ASTNode when generating docs
#14050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this depend on #14048 in any other way than that it is mentioned in the documentation as a typical use case? |
|
No, just referenced in the docs. At least wanted to call that out as if something came up where the other was delayed, this one should have that changed to avoid confusing docs if they dont make it into the same release. |
|
Then let's remove that dependency. It's easier to focus on each individual change independently. |
Can be re-added within a follow up PR once both this and that PR are merged
|
@straight-shoota Done. I removed the references from the macro docs. Can be re-added within a follow up PR once both this and #14048 are merged. |
Sija
reviewed
Dec 5, 2023
straight-shoota
approved these changes
Dec 6, 2023
straight-shoota
changed the title
ASTNode when generating docsASTNode when generating docs
straight-shoota
added
topic:lang:macros
topic:stdlib:macros
and removed
topic:stdlib:macros
topic:lang:macros
labels
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.