Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatter to skip trailing comma for single-line parameters #14713

Merged

Conversation

Blacksmoke16
Copy link
Member

Follow up to #13169 to fix a trailing comma erroneously being added when parameters are not multi-line

@Blacksmoke16 Blacksmoke16 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:formatter labels Jun 14, 2024
@straight-shoota straight-shoota added this to the 1.13.0 milestone Jun 14, 2024
@straight-shoota straight-shoota changed the title Ensure trailing commas are not written when parameters are not multi-line Fix formatter to skip trailing comma for single-line parameters Jun 16, 2024
@straight-shoota straight-shoota merged commit 6a2097d into crystal-lang:master Jun 16, 2024
61 checks passed
@Blacksmoke16 Blacksmoke16 deleted the fix_trailing_comma branch June 18, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:formatter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants