-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable pending formatter features #14718
Enable pending formatter features #14718
Conversation
Update specs
Update specs
Update specs
I noticed an issue: #14209 and #14075 (partially) are backwards-incompatible changes. Two formatters, one with the changes enabled and one with it disabled, cannot agree on a common accepted style as a valid variant. We could ensure a smooth transition by first releasing a version of the formatter which doesn't change old style to new style, but accepts the new style and does not change it back to old style. For example the change in #12951 is backwards compatible. The current formatter accepts the |
Alright, I'll see if I can put something together for that to include in this release. Then can release the part that'll migrate old to new in the next one. |
CI seems to be failing due to:
🤔 |
Looks like Docker hub was unavailable... There are some legitimate spec failures though (e.g. https://github.com/crystal-lang/crystal/actions/runs/11023991475/job/30616353981?pr=14718). |
I figured there would be, discovered #15033 when running the specs locally so figured I'd let CI run while figuring what was going on there. |
Apply changes to rest of codebase again
This pull request has been mentioned on Crystal Forum. There might be relevant details there: https://forum.crystal-lang.org/t/upcoming-release-1-15-0/7537/1 |
Enables the first batch of ready formatter features as called out in #13002.
&
to yielding methods without a block parameter #12951 (-Dmethod_signature_yield
)-Ddef_trailing_comma
)ProcLiteral
s #14209 (-Dproc_literal_whitespace
)NOTE: Depends on #14713