Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stdout output #13

Merged
merged 4 commits into from
Jan 14, 2023
Merged

Add stdout output #13

merged 4 commits into from
Jan 14, 2023

Conversation

tlvince
Copy link
Contributor

@tlvince tlvince commented Jun 6, 2022

Unfortunately GitHub Advanced Security (for the SARIF feature) is unavailable for private repos on github.com. As an alternative, Slither's markdown report can be used.

This sets outputs.stdout (which is required to be a single-line string) and adds example usage to the readme. See tlvince/hardhat-project#1 (comment) to see how it looks.

@CLAassistant
Copy link

CLAassistant commented Jun 6, 2022

CLA assistant check
All committers have signed the CLA.

@stephenctw
Copy link

Nice work! I faced the same issue that Github Advanced Security is not available for private repos. The way I worked around it is to add another step to parse the SARIF report into github annotation.
https://github.com/marketplace/actions/process-sarif-file

@abcfy2
Copy link

abcfy2 commented Jan 12, 2023

Really need this feature, we need to use the markdown report. Please merge this PR. Thanks.

@elopez elopez changed the base branch from main to dev January 13, 2023 14:36
@elopez
Copy link
Member

elopez commented Jan 13, 2023

Thanks for the PR @tlvince! I've merged dev to update the branch, updated the README to match, and modified the escaping code to use the new multiline strings feature on Actions output. I think we can merge this now, unless you have any objections to the changes I did.

@tlvince
Copy link
Contributor Author

tlvince commented Jan 13, 2023

lgtm 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants