Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark git repositories as safe inside the slither-action container #50

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

elopez
Copy link
Member

@elopez elopez commented Feb 9, 2023

@CodeSandwich
Copy link

Yes, it's working 🎉 The successful CI run: https://github.com/radicle-dev/drips-contracts/actions/runs/4136557972/jobs/7150586465

@CodeSandwich
Copy link

This seems to be a fairly important fix, I don't know what was changed in GH runners, but it probably broke more than just my CI. Are you planning to make a release of a new version so the fix is more accessible?

@FestusMaria
Copy link

Confirm that it's working on my CI too, but Github status does not work as expected. It always marked job status as passing even finding is detected. Not sure if this is a separated issue.

@elopez elopez merged commit 67b91ad into dev Feb 17, 2023
@elopez
Copy link
Member Author

elopez commented Feb 18, 2023

@almost-llamas that appears to be a separate issue introduced with #13; I merged a fix in #51 today. Let me know if you still experience that when using the dev branch.

@CodeSandwich I'll try and prepare a new release early next week 👍

@FestusMaria
Copy link

@almost-llamas that appears to be a separate issue introduced with #13; I merged a fix in #51 today. Let me know if you still experience that when using the dev branch.

@CodeSandwich I'll try and prepare a new release early next week 👍

Thanks! It works flawlessly. 🎉

scottynomad added a commit to nori-dot-eco/contracts that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants