Dvr pixel selector

[moralejo]

This scripts uses DL1 files to identify (event-wise) pixels likely containing a signal, and creates hdf5 files with this information for use in the raw data volume reduction.

There are no tests for this script as of now, it requires to have DL1 files with the DL1a images. Are they produced? At the end of the tests the created DL1 files only have DL1b.

[gabemery]

There are no tests for this script as of now, it requires to have DL1 files with the DL1a images. Are they produced? At the end of the tests the created DL1 files only have DL1b.

This test seems to write data

cta-lstchain/lstchain/tests/test_lstchain.py

Line 38 in 78223b7

def test_r0_to_dl1_observed(tmp_path):

You may be able to chain your tests after this one.

I am not convinced by the current script usage. Running twice the same script, the second time using the output of the first and adding a flag feel non intuitive. Maybe use a "processing_step" input parameter which can be 'settings', 'pixelmask' or 'both' depending on if you want to run step one, two or both directly?

[moralejo]

Thanks @gabemery . Now the script is steered in this way:

lstchain_dvr_pixselector --action compute_dvr_settings ... (which is the default)

or

lstchain_dvr_pixselector --action create_pixel_masks ...

I think it is more clear in this way.
(I did not add the "both" option, which would be somewhat complicated to implement)

As for the test, I will try, thanks!

[codecov]

Codecov Report

Patch coverage: 91.49% and project coverage change: +0.35 🎉

Comparison is base (8fb5cb5) 74.02% compared to head (94b1a8e) 74.38%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1089      +/-   ##
==========================================
+ Coverage   74.02%   74.38%   +0.35%     
==========================================
  Files         123      124       +1     
  Lines       11869    12116     +247     
==========================================
+ Hits         8786     9012     +226     
- Misses       3083     3104      +21     

Impacted Files	Coverage Δ
lstchain/scripts/lstchain_dvr_pixselector.py	90.94% <90.94%> (ø)
lstchain/conftest.py	97.65% <100.00%> (+0.07%)	⬆️
lstchain/scripts/tests/test_lstchain_scripts.py	99.66% <100.00%> (+0.01%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[moralejo]

All ready from my side.